add logic to ensure that the hooks inside of the woocommerce/src/ are parsed #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being parsed and add some steps to run this site locally
piinthecloud
requested review from
jorgeatorres,
bacoords and
a team
and removed request for
bacoords
bacoords
reviewed
Jul 23, 2025
There was a problem hiding this comment.
Hey @piinthecloud!
Thanks for the PR 💯. It works beautifully and I can confirm that the missing hooks are now present in the docs.
As for the local script, I left some small suggestions. Nothing's really a blocker, though. Please let me know what you think! Thanks again!
|
@jorgeatorres any additional concerns? |
jorgeatorres
approved these changes
Aug 5, 2025
There was a problem hiding this comment.
LGTM. This works great. Thank you @piinthecloud and apologies for the delay in finishing the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the WooCommerce Code Reference Generator to support local development workflows by and improving the recursive file scanning to detect hooks in woocommerce/src and deeper subdirectories.
Expanded file parsing
Added
woocommerce/srcto parsed files: The logic ingenerate-hook-docs.phphas been updated to know also look insidewoocommerce/srcto detect hooks and filters in use.Fixed
generate-hook-docs.phprecursion: During testing, I detected that thegetFiles()function wasn't going deep enough into the directories to appropriately retrieve all hook references. I simplified the logic on line 113 to directly merge the files from each subdirectory directly into the$filesarray.Hook and filter detection: Increased from 1,732 to 2,580 hooks.
Local development
To facilitate development, I've added the
run-local.shwhich lets you easily set up a local server with a local copy of the docs.Tweaks
Updated the .gitignore to ensure linked
/woocommercefiles never get committed.